feat: Adding get_phy_info functionality #35
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanveerThanu1
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to retrieve PHY (Physical Layer) information from network adapters on Windows systems using WMI queries. The implementation focuses on extracting auto-negotiation bits from PHY data.
Key Changes:
- Added
get_phy_info()method to query PHY information via PowerShell WMI commands - Implemented parsing logic to extract and decode auto-negotiation bits from PHY data
- Added adapter name normalization and matching logic to support specific adapter queries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThanveerThanu1
force-pushed
the
MFD-7556
branch
2 times, most recently
from
a95d29e to
181631f
Compare
ThanveerThanu1
changed the title
ThanveerThanu1
force-pushed
the
MFD-7556
branch
2 times, most recently
from
5a56203 to
3845487
Compare
mchromin
requested changes
Nov 21, 2025
mchromin
requested changes
Nov 21, 2025
Contributor
mchromin
left a comment
mchromin
left a comment
There was a problem hiding this comment.
Please git squash commits. Also , please remove jira ID from the commit msg as jira is accessible only to Intel employees and this module is open-source ;)
feature: Adding get_phy_info functionality under mfd_network_adapter\network_interface\feature\utils\windows.py Signed-off-by: ThanuThanveer1 [email protected]
ThanveerThanu1
force-pushed
the
MFD-7556
branch
from
7b22ad2 to
a8947ae
Compare
ThanveerThanu1
changed the title
Author
|
Closing this due to failing checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: Adding get_phy_info functionality under mfd_network_adapter\network_interface\feature\utils\windows.py